Update dependency reselect to ^4.1.8 #3678
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^4.0.0
->^4.1.8
Release Notes
reduxjs/reselect (reselect)
v4.1.8
Compare Source
This release updates our build tooling, tweaks the
MergeParameters
type to better handle spread values, and fixes an erroneous.clearCache()
method included on theresultFunc
.What's Changed
main
by @markerikson in https://github.com/reduxjs/reselect/pull/606Full Changelog: reduxjs/reselect@v4.1.7...v4.1.8
v4.1.7
Compare Source
This release updates the TS types to work correctly with TS 4.9, which made a change that broke the existing
MergeParameters
type implementation. Happily, the TS team provided a better (and simpler!)MergeParameters
implementation. Since that only works with TS 4.7+, we've reworked the internals to handle providing the old implementation to TS 4.2..4.6, and the new implementation to TS 4.7 and greater.As a user, there should be no visible change - just update to 4.1.7.
What's Changed
Full Changelog: reduxjs/reselect@v4.1.6...v4.1.7
v4.1.6
Compare Source
This release updates the TS types to better handle cases with default parameters, or
any/unknown
types.What's Changed
Full Changelog: reduxjs/reselect@v4.1.5...v4.1.6
v4.1.5
Compare Source
This release updates the TS types to correctly infer selector parameters when input selectors have
undefined
ornull
as a parameter type or have optional parameters, and exports theCreateSelectorFunction
type to fix uses ofcreateStructuredSelector
.(The types fixes feel like playing whack-a-mole, but they keep getting better!
What's Changed
Full Changelog: reduxjs/reselect@v4.1.4...v4.1.5
v4.1.4
Compare Source
This release has (you guessed it) more fixes to the TS types: a change to parameter merging that fixes breakage with selectors and RTK Query's API state, a simplification of the
OutputSelectorFields
type to improve selector variable readability, another update to parameter merging to flag nestednever
fields as compile errors, and a fix tocreateStructuredSelector
parameters to resolve a lib compilation problem.Changelog
More TS Fixes
The parameter merging fixes in 4.1.3 tried to "unwrap/expand" the parameter types to make them more readable, such as showing intersected objects as
{a, b, c}
instead of{a} & {b} & {c}
. This was done with a recursive expansion type. That turned out to break with the complex state types used by RTK Query. We've updated the type expansion to only be a single level instead, which fixes the compilation issue.The
OutputSelectorFields
type previously took two generics: theCombiner
function, and aResult
type. This led to extra values being shown in hover previews for selectors. By inferringResult = ReturnType<Combiner>
, we were able to drop the second generic and cut down on the amount of types shown in previews.A user noted that intersected objects with top-level incompatible fields (like
{a: string} & {a: number}
) resulted in empty objects, but no compile error. We've updated the parameter merging to flag those asnever
and catch the problem at compile time. Deeper nested incompatible fields should already be caught by TS.The previous fix to
createStructuredSelector
missed a step in the spreading process, which has now been fixed.What's Changed
Full Changelog: reduxjs/reselect@v4.1.3...v4.1.4
v4.1.3
Compare Source
This release rewrites the TS type inference of input selector parameters for correctness, fixes inference of
createStructuredSelector
inputs, and fixes an issue with theOutputSelectorFields
type not being exported.Changelog
Input Selector Parameter Inference Improvements
Reselect's types have always been extremely tricky, because it involves passing multiple input selectors with potentially heterogeneous, and then nested function composition of multiple selectors. Additionally, the input selectors can be passed as individual arguments or a single array of input selectors.
The 4.0.0 typedefs dealt with this by hand-writing dozens of overloads, which was absolutely impossible to maintain.
In 4.1, we took advantage of TS's improved abilities to infer array/tuple types to consolidate the typedefs.
One of the issues that happened as a result was that arguments at the same input parameter index were being "unioned" together, rather than "intersectioned". For example, in this complex selector:
The second arg should end up as an object like
{testNumber: number, testString: string, testBoolean: boolean, testString2: string}
. However, it was ending up as four separate one-field objects. Similarly, the combination ofnumber
andnumber | string
should be narrowed down to justnumber
as an acceptable value.We've rewritten the types to successfully accomplish that (although it took a lot of collective effort and headbanging to actually pull this off!) This should now give much more correct results when determining the final parameters that can be passed to a selector.
createStructuredSelector
FixesSimilarly,
createStructuredSelector
wasn't always inferring its arguments properly. We were able to reuse the parameter inference work here as well.OutputSelectorFields
ExportedThe public
OutputSelector
type depended on an internalOutputSelectorFields
type, but sinceOSF
wasn't being exported, TS would throw errors when trying to generate declaration files that exported selectors. That is now public as well.What's Changed
Full Changelog: reduxjs/reselect@v4.1.2...v4.1.3
v4.1.2
Compare Source
This release updates the TS types to avoid TypeScript recursion limitations and improve backwards compatibility, adds doc comments to most of the TS types and field declarations, and fixes a bug with the behavior of the
resultEqualityCheck
option indefaultMemoize
.Changelog
TypeScript Updates
We saw cases where composition of selectors past 8-9 levels of nesting would cause TS to fail with a "Type instantiation is excessively deep and possibly infinite" error.
We've updated the types to allow additional recursion up to about 15 levels of nested selectors. Hopefully this is enough for most usages :)
The
OutputSelector
generic arguments had been swapped during the rewrite for 4.1, which made it incompatible with other code that attempted to import and use that type. We've reverted the generic arguments to their previous order to fix compatibility.defaultMemoize
adds a.clearCache()
field to its return value. While the real caching is done by thememoizedResultFunc
function, the actual returned selector has also been run through the memoizer and thus also has a.clearCache()
field attached, but that wasn't captured in the types. We've updated the types to reflect that.We've also added doc comments to almost all of the internal types for clarity, as well as comments to the returned fields on selectors.
resultEqualityCheck
BehaviorThe
resultEqualityCheck
option wasn't saving the result if there was a cache hit, which is now fixed.What's Changed
New Contributors
Full Changelog: reduxjs/reselect@v4.1.1...v4.1.2
v4.1.1
Compare Source
This releases fixes several TS issues and one runtime issue that were reported with the release of 4.1.0.
Changelog
TypeScript Fixes
All these reported issues should now be fixed:
createSelector
calls with 12 or more input selectors were causing TS to fail with a "Type instantiation is excessively deep" error. After this update,createSelector
should now support up to 29 input selectors before TS has type issues. (and if you've got more than 29 input selectors.... what are you doing? :) )(a: number) => 42, (b: string) => 123
)OutputParametricSelector
type, which is re-exported by Redux Toolkit, was inadvertently left out of the list of Reselect type exports during the rewrite and caused RTK builds to failSomeType | undefined
were causing the entire selector to be typed as possibly returningundefined
Caching Undefined Values
The previous internal cache logic had a couple of
if (foundValue !== undefined)
checks inside, but that broke cases where a selector intentionally wanted to returnundefined
as the actual result.The cache logic has been updated to use an internal sentinel value as the
NOT_FOUND
result instead, allowingundefined
to be correctly cached and returned.What's Changed
GetStateFromSelectors
by @phryneas in https://github.com/reduxjs/reselect/pull/529undefined
by @markerikson in https://github.com/reduxjs/reselect/pull/532New Contributors
Full Changelog: reduxjs/reselect@v4.1.0...v4.1.1
v4.1.0
Compare Source
This long-overdue release updates
defaultMemoize
to accept new options for cache size > 1 and a result equality check, updatescreateSelector
to accept an options object containing options for the providedmemoize
function, makes major improvements to the TypeScript types (targeting TS 4.2+), converts the codebase to TS, improves some error messages, and addsmemoizedResultFunc
andlastResult
to the fields attached to the selector,This should be a drop-in update - the only expected backwards compatibility issues are with incorrect or very outdated TypeScript usage patterns.
Changelog
New
defaultMemoize
OptionsdefaultMemoize
has always been fairly limited. Its signature was(func: Function, equalityCheck?: EqualityFn) => Function
, and only ever had a cache size of 1. This has led to many annoyances and workarounds, typically involving callingcreateSelectorCreator()
with a custom memoization function that has a larger cache size or more options for customizing comparisons.We've updated
defaultMemoize
to allow cache sizes > 1, as well as customize comparisons of the newly generated result value to improve cache hits.The signature for
defaultMemoize
is now:In other words, you can still pass
equalityCheck
as its one additional arg, or you may pass an object containing several possible options.If the
maxSize
value is greater than 1,defaultMemoize
will now use an LRU cache based on https://github.com/erikras/lru-memoize internally.If
resultEqualityCheck
is provided, it will be used to compare the newly-generated value fromfunc
against all other values in the cache, in LRU order. If a cached value is found to be equal, that value will be returned. This addresses the commontodos.map(todo => todo.id)
use case, where a change to any field in anytodo
object creates a newtodos
array and thus causes the output to be recalculated, but the generated IDs array is still shallow-equal to the last result. You can now pass an equality function likeshallowEqual
as theresultEqualityCheck
argument, and it will reuse the old IDs array instead.createSelector
OptionsPreviously, the only way to customize behavior of
createSelector
was to generate a customized version withcreateSelectorCreator
. By far the most common use case was customizing theequalityCheck
option used withdefaultMemoize
, or using a different memoizer entirely. This usually looked like:createSelectorCreator
also accepted additional positional parameters, and forwarded all of them to the providedmemoize
function, sodefaultMemoize
ultimately gets called internally asdefaultMemoize(actualFunction, shallowEqual)
.This added an annoying level of indirection to common customization use cases.
createSelector
now accepts an options object as its last argument, after the output selector. Currently, that object only includes one field:memoizeOptions
:Similar to how
createSelectorCreator
accepts additional "options args" that get forwarded to the memoization function, thememoizeOptions
field accepts an array of those "options args" as well. If provided, these override what was given tocreateSelectorCreator
.That means that you can now customize memoization behavior with direct options to
createSelector
. And, becausedefaultMemoize
now accepts more options, you can directly customizedefaultMemoize
's behavior without usingcreateSelectorCreator
.Additionally, because it's very common to only need to pass one options arg to the memoization function,
memoizeOptions
may also be just that first options arg by itself, without any array.Example usages of this look like:
This should make it much easier to customize behavior.
All of this is fully TypeScript-typed, and the possible values for
memoizeOptions
should be fully inferred from the providedmemoize
function.Additionally,
defaultMemoize
now supports clearing the cache inside a memoized function (regardless of cache size). The memoized function returned fromdefaultMemoize
will now have a.clearCache()
method attached that will clear the cache.When using
createSelector
, this can be accessed usingselector.memoizedResultFunc.clearCache()
.TypeScript Improvements
The Reselect types were written several years ago and originally targeted TS 2.x versions. As a result, the typedefs requires dozens of overloads to handle varying numbers of arguments (see the legacy typedefs file for examples).
We've converted the codebase to be written in TypeScript, and as part of that process we've completely rewritten the TS typedefs to use modern TS syntax like mapped types. This drastically shrinks the size of the typedefs (from 1000 lines to about 115), and also improves the actual type inference overall. Assuming the input selectors are correctly and consistently typed, TS will now fully infer the return values of all input selectors, the arguments to the output selector, and the exact type of the memoized function.
The updated types do require use of TS 4.2+. We've attempted to keep the final public type names and usage the same, but there may also be some types breakage. We'd appreciate feedback on any meaningful breakage issues so we can make further tweaks if needed.
Given the intent of the improvements, that they're all type-only changes, the attempts to retain backwards compatibility, and TS's own versioning scheme, we're considering this to be a minor version change rather than a major.
In pre-release testing, the main issues we saw were:
state
arg. Fix: explicitly add a type tostate
<A, B, C, D>
generics from thecreateSelector()
call.The legacy types are still included, and should automatically be used if you are using TS 4.1 and earlier. Note that the legacy types do not include the definitions for the new
defaultMemoize
options - you'll need to be on TS 4.2+ to use those with TS.Additional Tweaks
We've improved the error messages thrown when invalid selectors are provided.
Generated selectors now include
selector.memoizedResultFunc
andselector.lastResult
for later access if needed.Changes
The early alphas contained code from several outstanding PRs, pulled together:
memoize
type fixes ( @micahbales )createStructuredSelector
inference ( @oatkiller )Additional work included:
defaultMemoize
to accept options (maxSize, equalityCheck, resultEqualityCheck) by @markerikson in https://github.com/reduxjs/reselect/pull/513clearCache
method to defaultMemoize output functions by @markerikson in https://github.com/reduxjs/reselect/pull/519Full Changelog: reduxjs/reselect@v4.0.0...v4.1.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.